Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
bufmode_t
enum was added tosrc/support/ios.h
in d316c93 by Jeff Bezanson with the commentIn 30aed86 Keno Fischer added a new comment and modified the enum:
In c12aca8 Jameson Nash removed
uv.h
and updated the enum definition to no longer useUV_HANDLE_TYPE_MAX
:This last change made the comment by Keno Fischer seemingly obsolete, yet the comment remains. This pull request simply removes the two lines remaining from Keno Fischer's commit. Perhaps it is better to update the comment to explain why
bm_none
now has the value1000
but I did not dig deep enough into the changes to figure out if this value is significant in some way that should be documented.